[Asterisk-code-review] cel/cel pgsql.cl: Add support schema on table name and fix q... (asterisk[master])

Rodrigo Ramirez Norambuena asteriskteam at digium.com
Sat Apr 25 19:47:59 CDT 2015


Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: cel/cel_pgsql.cl: Add support schema on table name and fix query columns name.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/120/3/cel/cel_pgsql.c
File cel/cel_pgsql.c:

Line 556: 				tmp_tablename = strchr(tmp_schemaname, '.');
> The previous code used strrchr to strip the schema name from the table:
Two things:
1.- I think so is better idea add schema var on configuration file.  

2.- Anyway, do it then change keep the original logic. 

Tell me if do you think is good or bad idea the point 1.


-- 
To view, visit https://gerrit.asterisk.org/120
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I691fd2cbc277fcba10e615f5884f8de5d8152f2c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list