[Asterisk-code-review] Update configure.ac/Makefile for clang (asterisk[13])

[Diederik de Groot]

Diederik de Groot has posted comments on this change.

Change subject: Update configure.ac/Makefile for clang
......................................................................


Patch Set 8:

I could not find another work around either (in the bug report or outside) and it cost me quite a little time to figure out how to circumvent the issue, without having to suppress -Warray-bounds altogether (which can be quite benefitial in other cases). Hopefully the glibc team or the llvm team will figure out a way to make this work in the future. At least this macro is prepared for it to be fixed.

The current version should be (as) ignorant (as possible) about the compiler by testing to see if it can compile the example/test when one of the required features is added. Only checking if it will not complain when an -f'parameter' is given is not enough. Older versions of both gcc and clang both allowed -f parameters on the command line for which they did not have support (which luckely has been corrected in newer versions). The linux kernel team had a big issue with that.

The -lBlocksRuntime is only required for older clang (<=3.2) versions. But newer ones would allow it's use (possibly with a little performance loss (not sure)).

Sorry for my previous 'fix' which was a little hasty and errornous.

-- 
To view, visit https://gerrit.asterisk.org/157
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12ea29d3bda2254ad3908e279b7effbbac6a97cb
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No