[Asterisk-code-review] Astobj2: Improve error logging from INTERNAL OBJ. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Astobj2: Improve error logging from INTERNAL_OBJ.
......................................................................


Patch Set 4:

(1 comment)

Sorry to expand the scope, but you did ask for it.

I've done basic testing - all astobj2 unit tests except the thrash tests.  I haven't had a chance to run the complete testsuite yet.  Given the size I'm sure there will be findings in the new patch, but if not please hold off +1 until it can be given proper/full testing.

https://gerrit.asterisk.org/#/c/140/4/main/astobj2_rbtree.c
File main/astobj2_rbtree.c:

Line 2077: 	const char *tag, const char *file, int line, const char *func, int ref_debug)
> ref_debug is no longer needed.  Since this is a vtable callback it isn't ne
Ripple effect it is.


-- 
To view, visit https://gerrit.asterisk.org/140
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3552721fe999365ba8a8cf00a965aa6b897cc1
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes