[Asterisk-code-review] chan pjsip: Creating Channel Causes Asterisk to Crash When D... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR Sections Exist in pjsip.conf
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/254/1//COMMIT_MSG
Commit Message:

Line 7: chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR Sections Exist in pjsip.conf
      : 
      : This patch modifies the current loading strategy to consider the entire
      : pjsip configuration as invalid if duplicate sections (e.g. sections containing
      : the same [id/type]) are defined in pjsip.conf. If a duplicate section
      : is encountered during load, the entire configuration is rejected and destroyed,
      : an error message is logged and the load processing stops.
As well - while this may have uncovered the bug it's not the bug in question. The real bug was in res_sorcery_config allowing multiple objects of the same id to exist.


https://gerrit.asterisk.org/#/c/254/1/res/res_sorcery_config.c
File res/res_sorcery_config.c:

Line 299: 			ast_log(LOG_ERROR, "Config file '%s' could not be loaded; configuration contains a duplicate object: '%s' of type '%s'\n",
        : 				config->filename, id, type);
        : 			ast_config_destroy(cfg);
        : 			return;
> ao2_find increases the reference count on obj. Make sure you drop the refer
obj is a RAII_VAR which calls ao2_cleanup, that cleans it up


-- 
To view, visit https://gerrit.asterisk.org/254
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35090ca4cd40f1f34881dfe701a329145c347aef
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes