[Asterisk-code-review] res pjsip outbound authenticator: Increase CSeq on authed re... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_outbound_authenticator: Increase CSeq on authed requests.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/249/1/res/res_pjsip_outbound_authenticator_digest.c
File res/res_pjsip_outbound_authenticator_digest.c:

Line 131: 		if (cseq) {
        : 			++cseq->cseq;
        : 		}
It shouldn't be possible for the cseq to not be present. The message would have failed creation long ago. I'd either be less paranoid, or make it an assert.


-- 
To view, visit https://gerrit.asterisk.org/249
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39c4ca52e688a9f83bcc1878371334becdc5be01
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes