[Asterisk-code-review] jira-release-update: Update script to support Git (repotools[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: jira-release-update: Update script to support Git
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/180/2/jira-release-update.py
File jira-release-update.py:

Line 53:        if len(issues) == 0:
       :             continue
> You removed an update of pbar from here in this revision, but it should sti
I removed that on purpose, as the increment of the progress bar is done for the same reason in both places.

The progress bar is set to the maximum number of messages to process. There are two ways to handle this:
* Each message that is processed moves the progress bar
* Each successfully processed message moves the progress bar

Keeping that code in that location contradicts your previous findings. Either we need to increment the progress bar on each message, or we need to increment the progress bar on each successfully processed message. A message with no issues is not a successfully processed message.

I'm fine either way, as in either case, the progress bar moves from 0 to finished.


-- 
To view, visit https://gerrit.asterisk.org/180
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82091b9213f607cdf4e78ffc580508a00c405ca4
Gerrit-PatchSet: 2
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes