[Asterisk-code-review] chan pjsip: Creating Channel Causes Asterisk to Crash When D... (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR Sections Exist in pjsip.conf
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/241/2/tests/channels/pjsip/configuration/test_harness.py
File tests/channels/pjsip/configuration/test_harness.py:

Line 66:         scenarios = list()
       :         for _ in range(0, self.test_object.asterisk_instances):
       :             scenario = TestScenario(config['cli_command'],
       :                                     config['re_query'])
       :             scenarios.append(scenario)
There's a shortcut notation you can use for this:

scenarios = [TestScenario(config['cli_command'], config['re_query'])] * self.test_object.asterisk_instances


Line 111:         LOGGER.debug('{0} Quering test scenarios.'.format(self))
s/Quering/Querying/


-- 
To view, visit https://gerrit.asterisk.org/241
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36078aae985050cff323ace3ccfd7464fe1de35f
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes