[Asterisk-code-review] Clang: Fix some more tautological-compare warnings. (asterisk[13])

Matt Jordan asteriskteam at digium.com
Thu Apr 23 15:10:29 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: Clang: Fix some more tautological-compare warnings.
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.asterisk.org/#/c/160/8/main/security_events.c
File main/security_events.c:

Line 430: 
        : 	ast_assert((unsigned int)event_type < AST_SECURITY_EVENT_NUM_TYPES);
This change is in https://gerrit.asterisk.org/#/c/231/, which means you will most likely get a merge conflict once that goes in.

As such, I'm going to hold off doing anything else with this until that goes in.

This change does need to be cherry-picked over to 11/master as well.


-- 
To view, visit https://gerrit.asterisk.org/160
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief23ef68916192b9b72dabe702b543ecfeca0b62
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list