[Asterisk-code-review] digium commits: Make module more tolerant to input data; add... (repotools[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: digium_commits: Make module more tolerant to input data; add some enhancements
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/178/2/digium_commits.py
File digium_commits.py:

Line 74:                 regex = "{0}\s* #close".format(regex)
> I had recommended using
Yeah, I like requiring:

ASTERISK-12345 #close

As opposed to:

ASTERISK-12345#close


-- 
To view, visit https://gerrit.asterisk.org/178
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05a3d667b9d56465232eb293682a66fe97c3aaef
Gerrit-PatchSet: 2
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes