[Asterisk-code-review] Clang: change previous tautological-compare fixes. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Clang: change previous tautological-compare fixes.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/231/1/main/event.c
File main/event.c:

Line 201: 	ast_assert((unsigned int) type < AST_EVENT_TOTAL);
        : 
        : 	if (type >= ARRAY_LEN(event_names)) {
The assert invalidates the if test.
Should be:

if ((unsigned int) type >= ARRAY_LEN())


-- 
To view, visit https://gerrit.asterisk.org/231
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0557ae0154a0b7de68883848a609309cdf0aee6a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes