[Asterisk-code-review] digium commits: Make module more tolerant to input data; add... (repotools[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: digium_commits: Make module more tolerant to input data; add some enhancements
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/178/1//COMMIT_MSG
Commit Message:

Line 31: Change-Id: I05a3d667b9d56465232eb293682a66fe97c3aaef
> The three Change-Id lines in here stick out. Why not just have the one at t
I was trying to find a way to separate out the changes in the three files, and originally it was three separate commits. I'll just combine them and provide some line spaces.


https://gerrit.asterisk.org/#/c/178/1/digium_commits.py
File digium_commits.py:

Line 74:                 regex = "{0} #close".format(regex)
> If we're trying to be tolerant of variances in user input, I suggest alteri
Fixed.


Line 94:         for match in re.finditer("[Tt]ested ?-?[Bb]y:?(.*)", self.message):
> The " ?-?" construct is a bit odd here. I'd think you'd want to have either
Good idea; fixed.


-- 
To view, visit https://gerrit.asterisk.org/178
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05a3d667b9d56465232eb293682a66fe97c3aaef
Gerrit-PatchSet: 1
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes