[Asterisk-code-review] res corosync: Add check for config file before calling coros... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_corosync: Add check for config file before calling corosync apis
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/223/5/res/res_corosync.c
File res/res_corosync.c:

Line 914: 	if (load_config(cfg, 0)) {
        : 		/* simply not configured is not a fatal error */
        : 		res = AST_MODULE_LOAD_DECLINE;
        : 		goto failed;
        : 	}
This is what I was referring to.  If load_config() failed it set the return value to DECLINE.  This patch doesn't change what happens here if load_config() returns non-zero.


-- 
To view, visit https://gerrit.asterisk.org/223
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf94a9431a4922ec4ec994003f02135acfdd3889
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes