[Asterisk-code-review] Astobj2: Ensure all calls to adjust lock pass a valid object. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Astobj2: Ensure all calls to __adjust_lock pass a valid object.
......................................................................


Patch Set 2:

I thought you just needed to add a reply on the finding itself.  But gerrit doesn't preserve reply relationships with findings.

Anyway, the assert is acceptable.  If the container data structures are so screwed up that the container pointer is invalid then we should crash.  It is a serious bug.

-- 
To view, visit https://gerrit.asterisk.org/221
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I669100f87937cc3f867cec56a27ae9c01292908f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No