[Asterisk-code-review] res corosync: Add check for config file before calling coros... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_corosync: Add check for config file before calling corosync apis
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Hmm.  The changes in this patch don't explain why asterisk aborts if the config file is missing or invalid.  Without the patch the return value already is set to DECLINE.

https://gerrit.asterisk.org/#/c/223/3/res/res_corosync.c
File res/res_corosync.c:

Line 786: 	ast_config_destroy(cfg);
This should move up to load_module() as well for balance.  Then it is always the caller that has to clean up cfg.


-- 
To view, visit https://gerrit.asterisk.org/223
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf94a9431a4922ec4ec994003f02135acfdd3889
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes