[Asterisk-code-review] ASTERISK-24983: Prevent deadlock between hanup and sending l... (asterisk[master])

Y Ateya asteriskteam at digium.com
Wed Apr 22 15:26:22 CDT 2015


Hello George Joseph,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/169

to look at the new patch set (#3).

Change subject: ASTERISK-24983: Prevent deadlock between hanup and sending lagrq/ping
......................................................................

ASTERISK-24983: Prevent deadlock between hanup and sending lagrq/ping

channels/chan_iax.c: Prevent the deadlock between iax2_hangup and send_lagrq/
send_ping. This deadlock happens because scheduled task send_lagrq(or send_ping)
start execution after call hangup procedure started but before deleting the
tasks the scheduler. The solution is to prevent lagrq (and ping) from acquiring
the mutex if call disappear or hangup in process. This commit cleans up the
procedure of sending LAGRQ and PING.

main/sched.c: Add warning message if scheduler is stuck while deleting and
executing task.

Change-Id: I03bec1fc8faacb89630269e935fa667c6d6c080c
---
M channels/chan_iax2.c
M main/sched.c
2 files changed, 73 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/69/169/3
-- 
To view, visit https://gerrit.asterisk.org/169
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03bec1fc8faacb89630269e935fa667c6d6c080c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Y Ateya <y.ateya at starkbits.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Y Ateya <y.ateya at starkbits.com>



More information about the asterisk-code-review mailing list