[Asterisk-code-review] cdr/cdr adaptive odbc.c check is nulleable column on table. (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: cdr/cdr_adaptive_odbc.c check is nulleable column on table.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/191/3/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 439: 			/* If column on table is not nulleable set empty value */
        : 			if (entry->nullable == 0 && colptr == NULL)  {
        : 				colptr = "";
        : 			}
I'm not sure I understand when this legitimately occurs.

Can you give an example schema/configuration that results in this happening?


-- 
To view, visit https://gerrit.asterisk.org/191
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05d7ce71254e74ff9a931ebe7b418d803b88bc54
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes