[Asterisk-code-review] Astobj2: Improve error logging from INTERNAL OBJ. (asterisk[master])

[Corey Farrell]

Hello Mark Michelson, Richard Mudgett,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/140

to look at the new patch set (#3).

Change subject: Astobj2: Improve error logging from INTERNAL_OBJ.
......................................................................

Astobj2: Improve error logging from INTERNAL_OBJ.

This converts INTERNAL_OBJ and is_ao2_object into macros, adds the ability
to use caller information in error logging.  They were converted to macros
to avoid the overhead of passing caller information when there is no error.

This also enables the REF_DEBUG parameters for __ao2_ref and __ao2_alloc
regardless of compiler defines.  This simplifies code, and I believe without
added overhead.  Although passing the 4 extra parameters to __ao2_ref does add
some overhead, internal_ao2_ref always took 3 of the parameters.  This change
merges __ao2_ref with internal_ao2_ref.  The same applies to __ao2_alloc and
internal_ao2_alloc, so they are also merged for the same reason.

ASTERISK-24974 #close
Reported by: Corey Farrell

Change-Id: Icf3552721fe999365ba8a8cf00a965aa6b897cc1
---
M apps/app_queue.c
M channels/chan_sip.c
M include/asterisk/astobj2.h
M main/astobj2.c
M main/astobj2_container.c
M main/astobj2_hash.c
M main/astobj2_private.h
M main/astobj2_rbtree.c
M main/channel_internal_api.c
M main/format_cap.c
M main/loader.c
M res/res_musiconhold.c
12 files changed, 188 insertions(+), 272 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/40/140/3
-- 
To view, visit https://gerrit.asterisk.org/140
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf3552721fe999365ba8a8cf00a965aa6b897cc1
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>