[Asterisk-code-review] res pjsip mwi: Send unsolicited MWI NOTIFY on startup and wh... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip_mwi: Send unsolicited MWI NOTIFY on startup and when endpoint registers.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

minor optional comment

https://gerrit.asterisk.org/#/c/175/2/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 823: 	struct ast_taskprocessor *serializer = mwi_sub->is_solicited ? ast_sip_subscription_get_serializer(mwi_sub->sip_sub) : NULL;
        : 
        : 		if (ast_sip_push_task(serializer, serialized_notify, ao2_bump(mwi_sub))) {
        : 			ao2_ref(mwi_sub, -1);
        : 		}
If you wanted this could just call "send_initial_notify" here since it is the same code.


-- 
To view, visit https://gerrit.asterisk.org/175
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043f20230227e91218f18a82c7d5bb2aa62b1d58
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes