[Asterisk-code-review] New AMI Command Output Format (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: New AMI Command Output Format
......................................................................


Patch Set 4: Code-Review+1

I'm giving +1, but this does break tests/apps/queues/set_penalty - the one testsuite use of starpy's ami.command I could find.

This is why I have previously stated that we should not merge this change until starpy is updated, doing so will break that queue test in trunk until starpy can deal with the new format.

If anyone has the idea to fix the queues/set_penalty test to use CLI directly, I'm fine with that.  If we do that we will need a new test: tests/manager/command.  Otherwise the Action: Command will have no test coverage.

-- 
To view, visit https://gerrit.asterisk.org/139
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6718d95490f0a6b3f171c1a5cdad9207f9a44888
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Gareth Palmer <gareth at acsdata.co.nz>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No