[Asterisk-code-review] pjsip: Refactor out various AMISendTest implementations (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: pjsip:  Refactor out various AMISendTest implementations
......................................................................


Patch Set 6:

(1 comment)

I love changes like this :)

https://gerrit.asterisk.org/#/c/153/6/tests/channels/pjsip/ami/show_registrations_inbound/test-config.yaml
File tests/channels/pjsip/ami/show_registrations_inbound/test-config.yaml:

Line 39:     -
       :         ami-events:
       :             conditions:
       :                 match:
       :                     Event: 'DeviceStateChange'
       :             requirements:
       :                 match:
       :                     Device: 'PJSIP/user1'
       :                     State: 'NOT_INUSE'
I noticed Matt said he was having this test fail. Consider changing the AMI event here to be

Event: TestEvent
State: AOR_CONTACT_ADDED

with requirements
AOR: user1

This event correlates more closely with the SIPp scenario's REGISTER request having been accepted.


-- 
To view, visit https://gerrit.asterisk.org/153
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d3e5298114bd4eb676537a816bc6e437036642b
Gerrit-PatchSet: 6
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes