[Asterisk-code-review] STERISK-24730 New AMI Command Output Format (asterisk[master])

Gareth Palmer asteriskteam at digium.com
Mon Apr 20 21:40:18 CDT 2015


Hello Mark Michelson, George Joseph, Corey Farrell,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/139

to look at the new patch set (#2).

Change subject: STERISK-24730 New AMI Command Output Format
......................................................................

STERISK-24730 New AMI Command Output Format

This change modifies how the the output from a CLI command is sent
to a client over AMI.

Output from the CLI command is now sent as a series of zero-or-more
Output: headers.

Additionally, commands that fail to execute (eg: no such command,
invalid syntax etc.) now cause an Error response instead of Success.

If the command executed successfully, but the manager unable to
provide the output the reason will be included in the Message:
header. Otherwise it will contain 'Command output follows'.

Depends on a new version of starpy (> 1.0.2) that supports the new
output format.

See pull-request https://github.com/asterisk/starpy/pull/34

Change-Id: I6718d95490f0a6b3f171c1a5cdad9207f9a44888
---
M UPGRADE.txt
M include/asterisk/manager.h
M main/cli.c
M main/manager.c
4 files changed, 46 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/39/139/2
-- 
To view, visit https://gerrit.asterisk.org/139
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6718d95490f0a6b3f171c1a5cdad9207f9a44888
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Gareth Palmer <gareth at acsdata.co.nz>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list