[Asterisk-code-review] testsuite: Remove some external dependencies for run-local (testsuite[master])

Corey Farrell asteriskteam at digium.com
Mon Apr 20 19:28:59 CDT 2015


Corey Farrell has posted comments on this change.

Change subject: testsuite: Remove some external dependencies for run-local
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/167/1/run-local
File run-local:

Line 64: 	export LD_LIBRARY_PATH="$HERE/$(dirname `find ./astroot -name libasteriskssl.so`)${LD_LIBRARY_PATH}"
How about:
LIBDIR=`dirname $HERE/astroot/usr/lib*/libasteriskssl.so`
export LD_LIBRARY_PATH="${LIBDIR}${LD_LIBRARY_PATH}"

It's easier to read with the command execution on it's own line.  Plus we don't need `find` since we have a predictable pattern for where to find the file.


-- 
To view, visit https://gerrit.asterisk.org/167
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf59b8b6de7524913ab4e3c29006e91a29d60e4e
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list