[Asterisk-code-review] Add test for PJSIP forward loops. (testsuite[master])

Mark Michelson asteriskteam at digium.com
Mon Apr 20 15:46:35 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: Add test for PJSIP forward loops.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/119/5//COMMIT_MSG
Commit Message:

Line 17: Address review feedback
       : 
       : * Remove trailing whitespace from test-config.yaml
       : * Change tag in test-config.yaml to "pjsip"
       : 
       : Change-Id: I5675c6d1642c53c7fcd8e0d5847b0c3d66798197
> I don't think this belongs... here...
Okay, so that brings up a good point.

I made two commits here. One that added the test, and one that addressed review feedback. So how do I indicate that this is two commits if I don't put this here? This is, after all, what squashing commits does by default. I just altered the Change-ID to be the same as previous.


-- 
To view, visit https://gerrit.asterisk.org/119
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5675c6d1642c53c7fcd8e0d5847b0c3d66798197
Gerrit-PatchSet: 5
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Jared K. Smith <jaredsmith at jaredsmith.net>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list