[Asterisk-code-review] clang warns about a tautological-compare, when it find compa... (asterisk[13])

Diederik de Groot asteriskteam at digium.com
Mon Apr 20 12:19:27 CDT 2015


Hello Matt Jordan, George Joseph,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/160

to look at the new patch set (#2).

Change subject: clang warns about a tautological-compare, when it find comparisons that are always true.
......................................................................

clang warns about a tautological-compare, when it find comparisons that are always true.

Exanple:
unsigned int x = 4;
if (x > 0)  // x is always going to be bigger than 0, so this is an unnecessary comparison.

Issue: ASTERISK-24917
Change-Id: Ief23ef68916192b9b72dabe702b543ecfeca0b62
---
M channels/chan_skinny.c
M main/security_events.c
M res/res_security_log.c
3 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/60/160/2
-- 
To view, visit https://gerrit.asterisk.org/160
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief23ef68916192b9b72dabe702b543ecfeca0b62
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list