[Asterisk-code-review] Make contrib/scripts/clang-scan-build executable Change-Id: ... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: Make contrib/scripts/clang-scan-build executable Change-Id: I70405fe54e4be7dbfbcb62e291690069b88617a8
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Since this is a new script, please update the CHANGES file indicating that a new script has been added, and what the script is for.

As this is a new feature/improvement, at a minimum, you'll need to cherry-pick this to master. I think this would also be appropriate for 11.

https://gerrit.asterisk.org/#/c/158/2//COMMIT_MSG
Commit Message:

Line 6: 
      : Make contrib/scripts/clang-scan-build executable
      : Change-Id: I70405fe54e4be7dbfbcb62e291690069b88617a8
1. Please provide a more complete description of what the change is fixing. The commit message is the only indication a year from now of what was changed and why.

2. Please reference the ASTERISK issue in the commit message.

You may want to read the commit message guidelines on the wiki:

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/158/2/contrib/scripts/clang-scan-build
File contrib/scripts/clang-scan-build:

Line 1: #!/bin/bash
      : SCANBUILD="scan-build"
      : if [ -z "`which clang`" ]; then
      : 	CCC_CC="clang"
      : 	CCC_CXX="clang++"
      : 	CFLAGS="-fblocks"
      : else
      : 	CCC_CC="gcc"
      : 	CCC_CXX="g++"
      : 	CFLAGS=""
      : fi
I would add a pre-amble the specifies the licensing of the file, the copyright, and the original author.

The live_ast script has the best template for this by far.

Granted, we're pretty terrible at being consistent with this in the scripts directory, but there's no reason to perpetuate that.


-- 
To view, visit https://gerrit.asterisk.org/158
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70405fe54e4be7dbfbcb62e291690069b88617a8
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes