[Asterisk-code-review] Fix clang-RAII implementation Removed the #error message (it... (asterisk[13])

George Joseph asteriskteam at digium.com
Mon Apr 20 11:48:17 CDT 2015


George Joseph has posted comments on this change.

Change subject: Fix clang-RAII implementation Removed the #error message (it creates complications compiling external projects against asterisk, using a different compiler then the one used to compile asterisk)
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/159/1//COMMIT_MSG
Commit Message:

Line 8: Removed the #error message (it creates complications compiling external projects against asterisk, using a different compiler then the one used to compile asterisk)
Line should be wrapped.


https://gerrit.asterisk.org/#/c/159/1/include/asterisk/utils.h
File include/asterisk/utils.h:

So is blocks not required or are you just removing the error?


-- 
To view, visit https://gerrit.asterisk.org/159
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12091228090e90831bf2b498293858f46ea7a8c2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list