[Asterisk-code-review] pjsip options: Fix non-qualified contacts showing as unavai... (asterisk[13])

Joshua Colp asteriskteam at digium.com
Mon Apr 20 06:30:13 CDT 2015


Joshua Colp has posted comments on this change.

Change subject: pjsip_options:  Fix non-qualified contacts showing as unavailable
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/147/4/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 513: 		update_contact_status(contact, UNKNOWN);
I'm curious - why did you opt to do this instead of keeping the assumption that lack of contact status = unknown?


-- 
To view, visit https://gerrit.asterisk.org/147
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbc01533ce57f0e4e584b89a395326e098b8fe7
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list