[Asterisk-code-review] pbx/callerid match: Close channels on shutdown. (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: pbx/callerid_match: Close channels on shutdown.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/137/2/tests/pbx/callerid_match/test-config.yaml
File tests/pbx/callerid_match/test-config.yaml:

Line 6:     # 12.x crashes on this test, never received the fix from ASTERISK-24774
      :     minversion: ['11.18.0', '12.99.0', '13.4.0']
If you don't want the 12 branch to run, simply omit it from the minversion list.

The minversion checking does the following:
1) If there is a minversion in the list that matches our branch, use it for the comparison.
2) If there is no minversion in the list that matches our branch, we must be greater than *all* minversions in the list.

Since the 12 branch will always be less than any minversion including 13.x, not providing a 12 minversion will force it to never run.

Specifying '12.99.0' will actually cause a checkout of the 12 branch to still run, as a branch checkout is always greater than any tagged version. It will run so long as a minversion of 12.x exists in the list of versions.


-- 
To view, visit https://gerrit.asterisk.org/137
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a1b421280d6d87a26fba01cc1005267aa3eab4c
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes