[Asterisk-code-review] pjsip options: Fix non-qualified contacts showing as unavai... (asterisk[master])

George Joseph asteriskteam at digium.com
Sun Apr 19 20:07:45 CDT 2015


Hello Matt Jordan,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/148

to look at the new patch set (#4).

Change subject: pjsip_options:  Fix non-qualified contacts showing as unavailable
......................................................................

pjsip_options:  Fix non-qualified contacts showing as unavailable

The "Add qualify_timeout processing and eventing" patch introduced
an issue where contacts that had qualify_frequency set to 0 were
showing Unavailable instead Unknown.  This patch checks for
qualify_frequency=0 and create an "Unknown"  contact_status
with an RTT = 0.

Previously, the lack of contact_status implied Unknown but since
we're now changing endpoint state based on contact_status, I've
had to add new UNKNOWN status so that changes could trigger the
appropriate contact_status observers.

ASTERISK-24977: #close

Change-Id: Ifcbc01533ce57f0e4e584b89a395326e098b8fe7
---
M funcs/func_pjsip_contact.c
M include/asterisk/res_pjsip.h
M res/res_pjsip/location.c
M res/res_pjsip/pjsip_configuration.c
M res/res_pjsip/pjsip_options.c
5 files changed, 51 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/48/148/4
-- 
To view, visit https://gerrit.asterisk.org/148
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcbc01533ce57f0e4e584b89a395326e098b8fe7
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list