[Asterisk-code-review] cdr/cdr odbc: Added to record new columns add on CDR 1.8 Ast... (asterisk[master])

[Rodrigo Ramirez Norambuena (Code Review)]

Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: cdr/cdr_odbc: Added to record new columns add on CDR 1.8 Asterisk Version
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/144/1//COMMIT_MSG
Commit Message:

Line 7: cdr/cdr_odbc: Added to record new columns add on CDR 1.8 Asterisk Version
      : 
      : New columns:
      :  * peeraccount
      :  * linkedid
      :  * sequence
      : 
      : Change-Id: Ibe0c7540a88305c6012786f438a0813ad8b19127
> 1. Please file an ASTERISK issue for this change. This change would affect 
if need add reference as "ASTERISK-24976" ?


https://gerrit.asterisk.org/#/c/144/1/cdr/cdr_odbc.c
File cdr/cdr_odbc.c:

Line 82: 	if (ast_test_flag(&config, CONFIG_LOGUNIQUEID)) {
       : 		snprintf(sqlcmd,sizeof(sqlcmd),"INSERT INTO %s "
       : 		"(calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,"
       : 		"lastdata,duration,billsec,disposition,amaflags,accountcode,"
       : 		"peeraccount,linkedid,sequence,"
       : 		"uniqueid,userfield)"
       : 		"VALUES ({ts '%s'},?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)", table, timestr);
       : 	} else {
       : 		snprintf(sqlcmd,sizeof(sqlcmd),"INSERT INTO %s "
       : 		"(calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,lastdata,"
       : 		"duration,billsec,disposition,amaflags,accountcode,"
       : 		"peeraccount,linkedid, sequence)"
       : 		"VALUES ({ts '%s'},?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)", table, timestr);
> This is a backwards incompatible change. Yes, it should have been done when
Ok, thanks for recommendations!.

1.- Where file UPGRADE should add this change? because the change by cherry-pick will not pass cleanly. 
2.- If need i make the cherry-pick?


-- 
To view, visit https://gerrit.asterisk.org/144
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe0c7540a88305c6012786f438a0813ad8b19127
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes