[Asterisk-code-review] Change in asterisk[13]: pjsip_options: Fix non-qualified contacts showing as unavai...

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: pjsip_options:  Fix non-qualified contacts showing as unavailable
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/147/2/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 490: 	} else {
        : 		status = find_or_create_contact_status(contact);
        : 		status->status = AVAILABLE;
        : 		status->rtt = 0;
        : 		if (ast_sorcery_update(ast_sip_get_sorcery(), status)) {
        : 			ast_log(LOG_ERROR, "Unable to update ast_sip_contact_status for contact %s\n",
        : 				contact->uri);
        : 		}
        : 	}
Since this code is the same as the block on line 1010, I'd go ahead and refactor it into a common subroutine.


-- 
To view, visit https://gerrit.asterisk.org/147
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbc01533ce57f0e4e584b89a395326e098b8fe7
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes