[Asterisk-code-review] Change in testsuite[master]: pjsip/qualify: Add test for contacts with qualify_frequency=0

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: pjsip/qualify: Add test for contacts with qualify_frequency=0
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/149/1//COMMIT_MSG
Commit Message:

Line 8: 
      : This test checks that contacts that have qualify_frequency=0
      : are marked as Available when they are created.
Is there an ASTERISK issue this should apply to as well?


https://gerrit.asterisk.org/#/c/149/1/tests/channels/pjsip/qualify/AMISendTest.py
File tests/channels/pjsip/qualify/AMISendTest.py:

Line 1: #!/usr/bin/env python
      : '''
      : Copyright (C) 2013, Digium, Inc.
      : Kevin Harwell <kharwell at digium.com>
      : George Joseph <george.joseph at fairview5.com>
      : 
      : This program is free software, distributed under the terms of
      : the GNU General Public License Version 2.
      : '''
This same file with very minor changes keeps showing up through all of the PJSIP AMI tests. That's usually sign that we're re-using code when it should be made generic and configurable.

Even if we don't want to do it on this issue - which I think is fine - we should at least open a new ASTERISK issue to improve this set of tests. At a minimum, this test case should get refactored into something common for the PJSIP tests.

The code duplication has to stop sometime :-)


-- 
To view, visit https://gerrit.asterisk.org/149
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7850ea087667eae7cf3645d54e7bd885cac32bf3
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes