[Asterisk-code-review] Change in testsuite[master]: pjsip/options: Add tests for qualify_timeout and max_initia...

Matt Jordan (Code Review) asteriskteam at digium.com
Fri Apr 17 15:36:10 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: pjsip/options:  Add tests for qualify_timeout and max_initial_qualify_time
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/92/8/tests/channels/pjsip/qualify/basic/test-config.yaml
File tests/channels/pjsip/qualify/basic/test-config.yaml:

Line 51:     minversion: '13.3.0'
Shouldn't this be 13.4.0?


https://gerrit.asterisk.org/#/c/92/8/tests/channels/pjsip/qualify/max_initial_qualify_time/test-config.yaml
File tests/channels/pjsip/qualify/max_initial_qualify_time/test-config.yaml:

Line 52:     minversion: '13.3.0'
And 13.4.0 here


https://gerrit.asterisk.org/#/c/92/8/tests/channels/pjsip/qualify/qualify_timeout/test-config.yaml
File tests/channels/pjsip/qualify/qualify_timeout/test-config.yaml:

Line 40:     minversion: '13.3.0'
13.4.0


-- 
To view, visit https://gerrit.asterisk.org/92
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id37260a9f6b9927fdd90bef73d43a97ce2445fa1
Gerrit-PatchSet: 8
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list