[Asterisk-code-review] Change in asterisk[13]: bridge.c: NULL app causes crash during attended transfer

[Richard Mudgett (Code Review)]

Richard Mudgett has posted comments on this change.

Change subject: bridge.c: NULL app causes crash during attended transfer
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/133/3/main/bridge.c
File main/bridge.c:

Line 4478: 	/* There is a race condition that makes it possible for the app to be NULL.
         : 	   Retrieve the app first thing in order to give the greatest chance of
         : 	   having a value */
Awkward second sentence.

There is a race condition that makes it possible for the app name to be NULL. Retrieve the app name before transferring the call in order to have the best chance that a value is present.


Also there is a reason people prefer block comments:
/*
 * comment text
 * comment text
 */

It makes the comment visible.  When you cram a multi-line comment between code statements like this it makes people wonder if you are tying to hide something. :)


-- 
To view, visit https://gerrit.asterisk.org/133
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5134b84c4524906d8148817719d76ffb306488ac
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes