[Asterisk-code-review] Change in asterisk[13]: res_pjsip: Refactor endpt_send_request to include transactio...

[Joshua Colp (Code Review)]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Refactor endpt_send_request to include transaction timeout
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/43/7/res/res_pjsip.c
File res/res_pjsip.c:

Line 3011: 	ret_val = endpt_send_transaction(ast_sip_get_pjsip_endpoint(), tdata, timeout,
If no timeout is specified I'd go ahead and still use the PJSIP provided function. It makes the impact of this change much less. Thoughts?


-- 
To view, visit https://gerrit.asterisk.org/43
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0778dc730d9689c5147a444a04aee3c1026bf747
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes