[Asterisk-code-review] Change in asterisk[master]: pjsip_options: Add qualify_timeout processing and eventing

[Joshua Colp (Code Review)]

Joshua Colp has posted comments on this change.

Change subject: pjsip_options: Add qualify_timeout processing and eventing
......................................................................


Patch Set 10: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/47/10/res/res_pjsip/location.c
File res/res_pjsip/location.c:

Line 200: 	aor_contacts = ast_sip_location_retrieve_aor_contacts(aor);
This can fail.


https://gerrit.asterisk.org/#/c/47/10/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 22: #include "asterisk/test.h"
Why is this... here...


Line 93: 			ao2_cleanup(contact);
contact always exists, ao2_ref


https://gerrit.asterisk.org/#/c/47/10/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 31: #include "asterisk/test.h"
Why is this here...


-- 
To view, visit https://gerrit.asterisk.org/47
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ce0528e58014da1324856ea537e7765466044a
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes