[Asterisk-code-review] Change in asterisk[master]: pjsip_options: Add qualify_timeout processing and eventing

[Mark Michelson (Code Review)]

Mark Michelson has posted comments on this change.

Change subject: pjsip_options: Add qualify_timeout processing and eventing
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

Only issues I had were style-related.

https://gerrit.asterisk.org/#/c/47/5/CHANGES
File CHANGES:

Line 143:    in seconds for a qualify.  The default is 3 seconds.  This overrides the 
There's a red blob here.


https://gerrit.asterisk.org/#/c/47/5/res/res_pjsip/location.c
File res/res_pjsip/location.c:

Line 196: 	struct ao2_container *aor_contacts;
        : 	struct ast_sip_aor *aor = obj;
        : 	struct ao2_container *container = arg;
        : 
        :     aor_contacts = ast_sip_location_retrieve_aor_contacts(aor);
        :     ao2_callback(aor_contacts, OBJ_MULTIPLE | OBJ_NODATA, cli_contact_populate_container, container);
        :     ao2_ref(aor_contacts, -1);
        :     return CMP_MATCH;
It looks like you have a mixture of tabs and spaces in this function.


-- 
To view, visit https://gerrit.asterisk.org/47
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ce0528e58014da1324856ea537e7765466044a
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes