[Asterisk-code-review] Change in asterisk[13]: pjsip_options: Add qualify_timeout processing and eventing

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: pjsip_options: Add qualify_timeout processing and eventing
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.asterisk.org/#/c/44/3/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 167: 	/*! Qualify timeout. 0 is diabled. */
        : 	unsigned int qualify_timeout;
Place at the end of the struct to avoid ABI issues.

It's up to you if you want to change this on the review for 'master' as well, as ABI isn't as big of a concern there.


Line 193: 	/*! Last status for a contact (default - unavailable) */
        : 	enum ast_sip_contact_status_type last_status;
Place at the end of the struct to avoid ABI issues.

It's up to you if you want to change this on the review for 'master' as well, as ABI isn't as big of a concern there.


Line 221: 	/*! Qualify timeout. 0 is diabled. */
        : 	unsigned int qualify_timeout;
Place at the end of the struct to avoid ABI issues.

It's up to you if you want to change this on the review for 'master' as well, as ABI isn't as big of a concern there.


Line 240: 	/*! Pointer to the actual contact. */
        : 	struct ast_sip_contact *contact;
I'd keep the pointer where it is in the struct to preserve ABI.

It's up to you if you want to change this on the review for 'master' as well, as ABI isn't as big of a concern there.


-- 
To view, visit https://gerrit.asterisk.org/44
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ce0528e58014da1324856ea537e7765466044a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes