[Asterisk-code-review] Change in asterisk[master]: res_pjsip: Add global option to limit the maximum time for i...

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/48/3//COMMIT_MSG
Commit Message:

Line 31: 
Since this is a new feature, having an ASTERISK issue is rather important, as that is what will get reported in the release summary. Do you mind filing one for this issue?


https://gerrit.asterisk.org/#/c/48/3/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 952: 	int max_time = ast_sip_get_max_initial_qualify_time();
Since this returns an unsigned int, should the variable be an unsigned int as well?


-- 
To view, visit https://gerrit.asterisk.org/48
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80498aa1ea9923277bef51d6a9015c9c79740f4
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes