[asterisk-bugs] [JIRA] (ASTERISK-30387) res_pjsip_dialog_info_body_generator: Does not support call pickup

[Michael Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-30387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=261620#comment-261620 ] 

Michael Newton commented on ASTERISK-30387:
-------------------------------------------

It's a regression from previous behaviour, has broken a feature that was previously working, and ASTERISK-24601 was marked as a bug (a major one at that) so it didn't seem out of line. Just got back into our chan_pjsip migration testing and was reminded of it.

> res_pjsip_dialog_info_body_generator: Does not support call pickup
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-30387
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-30387
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_dialog_info_body_generator
>    Affects Versions: 16.29.1
>            Reporter: Michael Newton
>
> The patch that closed ASTERISK-24601 failed to add the {{call-id}}, {{local-tag}}, and {{remote-tag}} attributes to the {{<dialog>}} element, which were previously present in chan_sip. This omission prevents native call pickup from working with Polycom phones.
> SIP message with chan_sip:
> {noformat}
> NOTIFY sip:7141 at 192.168.0.117 SIP/2.0
> Via: SIP/2.0/UDP 12.34.56.78:5060;branch=z9hG4bK2768e541;rport
> Max-Forwards: 70
> From: <sip:7040 at pbx.example.ca>;tag=as797100f8
> To: "7141" <sip:7141 at pbx.example.ca>;tag=DF4A420E-5CE317BB
> Contact: <sip:7040 at 12.34.56.78:5060>
> Call-ID: 631012da4d0d149cfdc6736329a44e18
> CSeq: 115 NOTIFY
> User-Agent: FPBX-15.0.24(13.29.2)
> Subscription-State: active
> Event: dialog
> Content-Type: application/dialog-info+xml
> Content-Length: 615
> <?xml version="1.0"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="13" state="full" entity="sip:7040 at pbx.example.ca">
>         <dialog id="7040" call-id="pickup-631012da4d0d149cfdc6736329a44e18" local-tag="DF4A420E-5CE317BB" remote-tag="as797100f8" direction="recipient">
>                 <remote>
>                         <identity display="+12505551212">sip:2505551212 at pbx.example.ca</identity>
>                         <target uri="sip:2505551212 at pbx.example.ca"/>
>                 </remote>
>                 <local>
>                         <identity display="Mike">sip:7040 at pbx.example.ca</identity>
>                         <target uri="sip:7040 at pbx.example.ca"/>
>                 </local>
>                 <state>early</state>
>         </dialog>
> </dialog-info>
> {noformat}
> Message format with chan_pjsip:
> {noformat}
> NOTIFY sip:7141 at 56.78.90.12:5060 SIP/2.0
> Via: SIP/2.0/UDP 12.34.56.78:5060;rport;branch=z9hG4bKPjcdd2ab84-8417-42fa-ae14-b18e7b8e2366
> From: <sip:7040 at pbx.example.ca>;tag=09f61a19-a986-4a75-91ed-81059ee9e2f8
> To: "7141" <sip:7141 at pbx.example.ca>;tag=22CF8F07-6565921C
> Contact: <sip:12.34.56.78:5060>
> Call-ID: e2eaf295988a9c3643e3adb561a44e18
> CSeq: 2184 NOTIFY
> Event: dialog
> Subscription-State: active;expires=3516
> Allow-Events: presence, dialog, message-summary, refer
> Max-Forwards: 70
> User-Agent: FPBX-16.0.28(16.28.0)
> Content-Type: application/dialog-info+xml
> Content-Length:   553
> <?xml version="1.0" encoding="UTF-8"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" state="full" entity="sip:7040 at pbx.example.ca">
>         <dialog id="7040" direction="recipient">
>                 <remote>
>                         <identity display="+12505551212">sip:2505551212 at pbx.example.ca</identity>
>                         <target uri="sip:2505551212 at pbx.example.ca"/>
>                 </remote>
>                 <local>
>                         <identity display="Mike">sip:7040 at pbx.example.ca</identity>
>                         <target uri="sip:7040 at pbx.example.ca"/>
>                 </local>
>                 <state>early</state>
>         </dialog>
> </dialog-info>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)