[asterisk-bugs] [JIRA] (ASTERISK-30359) Install Prereq Script Enhancements

[Martin McCarthy (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-30359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=261526#comment-261526 ] 

Martin McCarthy edited comment on ASTERISK-30359 at 3/6/23 1:55 PM:
--------------------------------------------------------------------

==================================================
Code Review Feedback Updates from K
==================================================
- Alphabetically sort this list ✅ 2023-03-06 18:55:12
- Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14
- All indenting needs to be tabs ✅ 2023-03-06 18:57:53
- I don't think it's necessary to date every function here.  This is not a library/api file.  - Same goes for all the others. ✅ 2023-03-06 19:02:49
- Same as above.  Please fix all of these. ✅ 2023-03-06 19:03:21
- Don't need to write a 'done' comment for every return unless there's something special going on. ✅ 2023-03-06 19:03:49
- The function name here is obvious.  Each comment block doesn't need to repeat the function name.  Same goes for all the others. ✅ 2023-03-06 19:05:48
- Fix coding style; if [ condition ]; then;   dostuff; fi ✅ 2023-03-06 19:09:30
- Fix for 80 column terminals. ✅ 2023-03-06 19:29:54
- Test results for all distros ⏳(pending)
- In the comment blocks for each function.  Document the prerequisites for the function.  Describe what $PACKAGES_RH is supposed to be prior to the handle_rh() call. Same goes for all the other functions ⏳(pending)

Remaining effort estimate: 2 weeks.


was (Author: the_blode):
==================================================
Code Review Feedback Updates from K
==================================================
- Alphabetically sort this list ✅ 2023-03-06 18:55:12
- Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14
- All indenting needs to be tabs ✅ 2023-03-06 18:57:53
- I don't think it's necessary to date every function here.  This is not a library/api file.  - Same goes for all the others. ✅ 2023-03-06 19:02:49
- Same as above.  Please fix all of these. ✅ 2023-03-06 19:03:21
- Don't need to write a 'done' comment for every return unless there's something special going on. ✅ 2023-03-06 19:03:49
- The function name here is obvious.  Each comment block doesn't need to repeat the function name.  Same goes for all the others. ✅ 2023-03-06 19:05:48
- Fix coding style; if [ condition ]; then;   dostuff; fi ✅ 2023-03-06 19:09:30
- Fix for 80 column terminals. ✅ 2023-03-06 19:29:54
- Test results for all distros ⏳(pending)
- In the comment blocks for each function.  Document the prerequisites for the function.  Describe what $PACKAGES_RH is supposed to be prior to the handle_rh() call. Same goes for all the other functions ⏳(pending)

> Install Prereq Script Enhancements
> ----------------------------------
>
>                 Key: ASTERISK-30359
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-30359
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Contrib/General
>    Affects Versions: 20.0.0
>         Environment: Linux, BSD
>            Reporter: Martin McCarthy
>            Assignee: Martin McCarthy
>              Labels: Bash,, Contrib,, sh
>
> ========================================
> Install Prereq Script Enhancements
> ========================================
> Reporter: Martin McCarthy (The_Blode)
> Impacted Users: All users who install Asterisk.
> Affected Products: All Asterisk versions.
> Priority: Low / Lowest.
> Coding Time / Effort Estimate: 4 hours development / 4 hours QA testing.
> ========================================
> Description
> ========================================
> As you guys know, I'm getting into the world of Asterisk and file from #asterisk suggested that I use contrib/scripts/install_prereq but I noticed a few issues with it;
> - There was no debug in the terminal to tell me it was doing anything.
> - The help wasn't not very verbose.
> - Linux Mint was not supported.
> I've had a look at the script and proposed some changes;
> - Added a more verbose help menu.
> - Added error message for Mint users to inform them to submit a patch.
> - Reorganised and reformatted the source code to allow future patches to be submitted more easily.
> - Script verbosity has been increased.
> ========================================
> End
> ========================================



--
This message was sent by Atlassian JIRA
(v6.2#6252)