[asterisk-bugs] [JIRA] (ASTERISK-30236) app_queue.c: Don't escape commas in MONITOR_FILENAME.

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-30236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=260239#comment-260239 ] 

Asterisk Team commented on ASTERISK-30236:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

> app_queue.c: Don't escape commas in MONITOR_FILENAME.
> -----------------------------------------------------
>
>                 Key: ASTERISK-30236
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-30236
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: GIT, 19.6.0, 16.28.0, 18.14.0
>            Reporter: Sean Bright
>
> The contents of the {{MONITOR_FILENAME}} variable is evaluated when a queue member is connected to a caller, allowing information about the member to be included in the filename.
> This is made possible by using {{^\{MEMBERINTERFACE}}} syntax instead of {{$\{MEMBERINTERFACE}}} when assigning a value to {{MONITOR_FILENAME}} so that evaluation does not occur immediately. The {{MONITOR_EXEC}} variable is handled similarly.
> Because of the way that {{MONITOR_EXEC}} works under the hood, the code that performs the variable replacement also escapes commas before doing so. However, this replacement should be taking place _after_ the variable replacement is done so that unescaped commas are not erroneously passed to the MixMonitor start function.
> Finally, having a comma in a filename is not problematic so we now only escape commas after variable replacement is performed on {{MONITOR_EXEC}}.
> The main consequence of this change is that you can now use dialplan functions with multiple arguments in {{MONITOR_FILENAME}} without the commas being escaped before variable replacement occurs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)