[asterisk-bugs] [JIRA] (ASTERISK-30227) Audiosocket: provision to exit cleanly from app_audiosocket

[Péter Juhász (JIRA)]

Péter Juhász created ASTERISK-30227:
---------------------------------------

             Summary: Audiosocket: provision to exit cleanly from app_audiosocket
                 Key: ASTERISK-30227
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-30227
             Project: Asterisk
          Issue Type: Improvement
      Security Level: None
          Components: Applications/General
    Affects Versions: 18.14.0
            Reporter: Péter Juhász


App_audiosocket was added to Asterisk 18, and it provides a way to ferry audio data to and from an external program. However, it does not provide a way to exit cleanly from the application: even though the audiosocket protocol defines the way to end a session (with a specific "end session" packet type), and res_asterisk.c checks for this end session packet, the audiosocket_run function in app_audiosocket.c doesn't handle this case, in fact it does not ever return from the endless loop, except with -1 -- which in turn terminates the call.

However, closing the audiosocket connection remotely should not necessarily mean that the dialplan must terminate as well. We may want to redirect the user to some queue, do cleanup etc.

Therefore, I propose that app_audiosocket handle this case. It appears to be possible, I even have an experimental patch.



--
This message was sent by Atlassian JIRA
(v6.2#6252)