[asterisk-bugs] [JIRA] (ASTERISK-21741) [patch] - Improved Caller ID Diagnostics and Processing for FXO Channels

N A (JIRA) noreply at issues.asterisk.org
Fri Nov 25 20:01:51 CST 2022


    [ https://issues.asterisk.org/jira/browse/ASTERISK-21741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=260729#comment-260729 ] 

N A commented on ASTERISK-21741:
--------------------------------

I think this issue is dead at this point, but the attached patch from the reporter is wrong and should not be used. It completely violates the Caller ID specification by setting the name in the way that it does. You can't just do whatever you want. There are rules in the standard about how to decode and process Caller ID.

The correct thing to do is set the presentation on the channel to match the presentation in the Caller ID spill. There is a patch up on Gerrit that actually fixes the presentation issue: https://gerrit.asterisk.org/c/asterisk/+/19603

That change should fix this issue so I've referenced this there.

> [patch] - Improved Caller ID Diagnostics and Processing for FXO Channels
> ------------------------------------------------------------------------
>
>                 Key: ASTERISK-21741
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21741
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Channels/chan_dahdi, Core/CallerID
>    Affects Versions: 1.8.21.0, 13.18.4
>            Reporter: Vladimir Mikhelson
>              Labels: patch
>         Attachments: callerid.diff, chan_dahdi.diff
>
>
> Current implementation of callerid.c fails to pass the "flags" to the dial plan. As a result distinction between failed Caller ID detection, Failed Check Sum verification, Private Number, and Unknown Number and related Caller ID names becomes impossible. In all cases all we get back is NULL in both fields. On top of that callerid module assumes a non existent ability to request another Caller ID transmission from an analog channel in case the Caller ID check sum verification fails.
> A couple of simple patches I propose helped me with troubleshooting the Caller ID recognition on analog POTS lines as well as some enhancement to the dial plan based on flags processing.
> I did not test on any other channels but analog.  Possible implications could be expected on other channel types serviced by chan_dahdi and callerid modules.
> Somebody with better architectural knowledge of Asterisk components can easily enhance my patches or make them more universal or just more beautiful. This help is very welcome.



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list