[asterisk-bugs] [JIRA] (DAHTOOL-94) xusb_libusb: fails to compile on Debian 10

[N A (JIRA)]

     [ https://issues.asterisk.org/jira/browse/DAHTOOL-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

N A updated DAHTOOL-94:
-----------------------

    Description: 
I get this error when compiling DAHDI Tools on Debian 10:

make[3]: Entering directory '/usr/src/dahdi-tools-3.1.0/xpp/xtalk'
  CC       libxtalk_la-xusb_libusb.lo
xusb_libusb.c: In function ‘xusb_find_bypath’:
xusb_libusb.c:500:41: error: ‘/’ directive output may be truncated writing 1 byte into a region of size between 0 and 4093 [-Werror=format-truncation=]
    snprintf(devpath_tail, PATH_MAX, "%3s/%3s",
                                         ^
xusb_libusb.c:500:4: note: ‘snprintf’ output between 8 and 8194 bytes into a destination of size 4096
    snprintf(devpath_tail, PATH_MAX, "%3s/%3s",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     dev->bus->dirname, dev->filename);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


However, I don't get this error on Debian 11, which is odd.

Anyways, here is a patch that resolves this: https://raw.githubusercontent.com/InterLinked1/phreakscript/master/patches/xusb.diff

  was:
I get this error when compiling DAHDI Tools on Debian 10:

make[3]: Entering directory '/usr/src/dahdi-tools-3.1.0/xpp/xtalk'
  CC       libxtalk_la-xusb_libusb.lo
xusb_libusb.c: In function ‘xusb_find_bypath’:
xusb_libusb.c:500:41: error: ‘/’ directive output may be truncated writing 1 byte into a region of size between 0 and 4093 [-Werror=format-truncation=]
    snprintf(devpath_tail, PATH_MAX, "%3s/%3s",
                                         ^
xusb_libusb.c:500:4: note: ‘snprintf’ output between 8 and 8194 bytes into a destination of size 4096
    snprintf(devpath_tail, PATH_MAX, "%3s/%3s",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     dev->bus->dirname, dev->filename);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


However, I don't get this error on Debian 11, which is odd.

Fix is this:

char devpath_tail[PATH_MAX * 2 + 2];

line 500:
snprintf(devpath_tail, PATH_MAX * 2 + 2, "%3s/%3s",
                                dev->bus->dirname, dev->filename);



> xusb_libusb: fails to compile on Debian 10
> ------------------------------------------
>
>                 Key: DAHTOOL-94
>                 URL: https://issues.asterisk.org/jira/browse/DAHTOOL-94
>             Project: DAHDI-Tools
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>    Affects Versions: 3.1.0
>         Environment: Debian 10
>            Reporter: N A
>            Assignee: Duncan Patterson
>
> I get this error when compiling DAHDI Tools on Debian 10:
> make[3]: Entering directory '/usr/src/dahdi-tools-3.1.0/xpp/xtalk'
>   CC       libxtalk_la-xusb_libusb.lo
> xusb_libusb.c: In function ‘xusb_find_bypath’:
> xusb_libusb.c:500:41: error: ‘/’ directive output may be truncated writing 1 byte into a region of size between 0 and 4093 [-Werror=format-truncation=]
>     snprintf(devpath_tail, PATH_MAX, "%3s/%3s",
>                                          ^
> xusb_libusb.c:500:4: note: ‘snprintf’ output between 8 and 8194 bytes into a destination of size 4096
>     snprintf(devpath_tail, PATH_MAX, "%3s/%3s",
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      dev->bus->dirname, dev->filename);
>      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> However, I don't get this error on Debian 11, which is odd.
> Anyways, here is a patch that resolves this: https://raw.githubusercontent.com/InterLinked1/phreakscript/master/patches/xusb.diff



--
This message was sent by Atlassian JIRA
(v6.2#6252)