[asterisk-bugs] [JIRA] (ASTERISK-30093) res_pjsip_refer: Pickup event is not sent from refer_incoming_invite_request

[Jasper Hafkenscheid (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jasper Hafkenscheid updated ASTERISK-30093:
-------------------------------------------

    Attachment: res_pjsip_refer_call_pickup_stasis.patch

In the provided patch I exposed the `send_call_pickup_stasis_message` method from `pickup.c` and spliced it into `refer_incoming_invite_request` from `res_pjsip_refer.c`. 

This feels wrong, duplicating the code and exposing its internals. I think a better way would be to hook into `ast_do_pickup` from `pickup.c`, but have not gotten that to work.

> res_pjsip_refer: Pickup event is not sent from refer_incoming_invite_request
> ----------------------------------------------------------------------------
>
>                 Key: ASTERISK-30093
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-30093
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_refer
>    Affects Versions: 18.11.2
>            Reporter: Jasper Hafkenscheid
>            Assignee: Unassigned
>              Labels: patch
>         Attachments: debug.log, full-cel.csv, res_pjsip_refer_call_pickup_stasis.patch
>
>
> Similar to ASTERISK-28081, it seems that the stasis/cel PICKUP event is not sent when a call-pickup is performed using the INVITE with Replaces method.
> I have tried splicing in a function call to send_call_pickup_stasis_message, this fixes our tests that rely on this event. I suspect a better approach is possible by using the ast_do_pickup method, but have not gotten that to work.



--
This message was sent by Atlassian JIRA
(v6.2#6252)