[asterisk-bugs] [JIRA] (ASTERISK-13145) [patch] Presence subscription on Cisco SIP phone needs special Cisco-styled XML

[Samuel Rey (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=259610#comment-259610 ] 

Samuel Rey commented on ASTERISK-13145:
---------------------------------------

It seems the latest patch is not compatible with Asterisk 18.13.0 - here's the GCC output when compiling:

{noformat}
   [CC] parking/parking_applications.c -> parking/parking_applications.o
In file included from /usr/src/asterisk-18.13.0/include/asterisk/alertpipe.h:22,
                 from /usr/src/asterisk-18.13.0/include/asterisk/channel.h:125,
                 from /usr/src/asterisk-18.13.0/include/asterisk/pbx.h:26,
                 from parking/res_parking.h:29,
                 from parking/parking_applications.c:28:
parking/parking_applications.c: In function 'park_app_parse_data':
parking/parking_applications.c:310:29: error: 'MUXFLAG_REMINDER_OVERRIDE' undeclared (first use in this function); did you mean 'MUXFLAG_TIMEOUT_OVERRIDE'?
  310 |   if (ast_test_flag(&flags, MUXFLAG_REMINDER_OVERRIDE)) {
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/asterisk-18.13.0/include/asterisk/utils.h:67:21: note: in definition of macro 'ast_test_flag'
   67 |      ((p)->flags & (flag)); \
      |                     ^~~~
parking/parking_applications.c:310:29: note: each undeclared identifier is reported only once for each function it appears in
  310 |   if (ast_test_flag(&flags, MUXFLAG_REMINDER_OVERRIDE)) {
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/asterisk-18.13.0/include/asterisk/utils.h:67:21: note: in definition of macro 'ast_test_flag'
   67 |      ((p)->flags & (flag)); \
      |                     ^~~~
parking/parking_applications.c:311:8: warning: implicit declaration of function 'apply_option_reminder'; did you mean 'apply_option_timeout'? [-Wimplicit-function-declaration]
  311 |    if (apply_option_reminder(reminder_delay, opts[OPT_ARG_REMINDER])) {
      |        ^~~~~~~~~~~~~~~~~~~~~
      |        apply_option_timeout
parking/parking_applications.c:311:30: error: 'reminder_delay' undeclared (first use in this function)
  311 |    if (apply_option_reminder(reminder_delay, opts[OPT_ARG_REMINDER])) {
      |                              ^~~~~~~~~~~~~~
parking/parking_applications.c:311:51: error: 'OPT_ARG_REMINDER' undeclared (first use in this function)
  311 |    if (apply_option_reminder(reminder_delay, opts[OPT_ARG_REMINDER])) {
      |                                                   ^~~~~~~~~~~~~~~~
parking/parking_applications.c: In function 'park_common_setup2':
parking/parking_applications.c:546:2: error: too few arguments to function 'setup_park_common_datastore'
  546 |  setup_park_common_datastore(parkee, ast_channel_uniqueid(parker), comeback_override, randomize, time_limit,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
parking/parking_applications.c:382:12: note: declared here
  382 | static int setup_park_common_datastore(struct ast_channel *parkee, const char *parker_uuid, const char *comeback_override, int randomize, int time_limit, int reminder_delay, int silence_announce)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [/usr/src/asterisk-18.13.0/Makefile.rules:165: parking/parking_applications.o] Error 1
make: *** [Makefile:393: res] Error 2
root at pbx:/usr/src/asterisk-18.13.0#
{noformat}

> [patch] Presence subscription on Cisco SIP phone needs special Cisco-styled XML
> -------------------------------------------------------------------------------
>
>                 Key: ASTERISK-13145
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-13145
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Channels/chan_sip/NewFeature
>            Reporter: Gareth Palmer
>            Assignee: Gareth Palmer
>            Severity: Major
>              Labels: patch, pjsip
>         Attachments: 00_READ_ME_FIRST.txt, AppDialRules.xml, cisco-usecallmanager-13.38.2.patch, cisco-usecallmanager-16.24.0.patch, cisco-usecallmanager-18.10.0.patch, DialTemplate.xml, FeaturePolicy.xml, SEP84802DD55F9E.cnf.xml, SEP84802DD55F9E.cnf.xml, SEPMAC.cnf.xml, SoftKeys.xml, usecallmanager-port.sh
>
>
> This patch provides support for Cisco 6900, 7900, 8800 and 9900 series phones using the SIP firmware.
> Available features are: Busy Lamp Field, Off Hook Notification, Call Forward, Do Not Disturb, Huntgroup Login, Call Park (Notify and Monitor), Server-Side Ad-Hoc Conference, Conference List, Kick and Mute/Unmute, Multi-Admin Conference, Multiple Lines via Bulk Register, Immediate Divert, Call Recording, Restart or Reset via CLI, Call Pickup Notification, Call Back, Join Calls, Mallicious Call ID, Quality Reporting Tool and Fail-over/Fail-back.
> Also included is Application Server Events used by non-USECALLMANAGER phones (Call Forward and Do Not Disturb only).
> *Important:* Read the documentation at [http://usecallmanager.nz] to see the additional configuration options required for the phones to operate correctly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)