[asterisk-bugs] [JIRA] (ASTERISK-27774) res_musiconhold: Music on hold restarts after every announcement

[ben kolodny (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257831#comment-257831 ] 

ben kolodny commented on ASTERISK-27774:
----------------------------------------

i seem to have the same problem with version 18.9.0 but it after playing the thank you message when Announce position: is set to yes 
the code that was fixed checks just announcement maybe  position is treated differently
any tips would be appreciated  

if (!state->announcement) {
			state->samples += f->samples
[2022-01-24 18:50:36] VERBOSE[2643][C-00067771] app_queue.c: Nobody picked up in 20000 ms
[2022-01-24 18:50:37] VERBOSE[2643][C-00067771] res_musiconhold.c: Stopped music on hold on PJSIP/fs2-00036104
[2022-01-24 18:50:37] VERBOSE[2643][C-00067771] file.c: <PJSIP/fs2-00036104> Playing 'pbx/188d949a5b9bbde4553ef85f252d8ddf.slin' (language 'he')
[2022-01-24 18:50:40] VERBOSE[2643][C-00067771] app_queue.c: Told PJSIP/fs2-00036104 in 1507 their queue position (which was 1)
[2022-01-24 18:50:40] VERBOSE[2643][C-00067771] file.c: <PJSIP/fs2-00036104> Playing 'queue-thankyou.gsm' (language 'he')
[2022-01-24 18:50:42] VERBOSE[2643][C-00067771] res_musiconhold.c: Started music on hold, class '1435', on channel 'PJSIP/fs2-00036104'

> res_musiconhold: Music on hold restarts after every announcement
> ----------------------------------------------------------------
>
>                 Key: ASTERISK-27774
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27774
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_musiconhold
>    Affects Versions: 15.3.0
>            Reporter: laszlovl
>            Assignee: Unassigned
>            Severity: Major
>              Labels: pjsip
>      Target Release: 13.21.0, 15.4.0, 16.0.0
>
>
> The fix for ASTERISK-24329 is causing a regression during "regular" music on hold behavior.
> Imagine a simple musiconhold setup, configured via realtime.
> {code}
> +--------+-------+------------------------+-------+
> | name   | mode  | directory              | sort  |
> +--------+-------+------------------------+-------+
> | 82497  | files | /ext/moh/82497         | alpha |
> {code}
> In /ext/moh/82497 are one or more audio files with a length of around 3 minutes. If a queue is configured with a periodic announcement every 30 seconds, the following will occur:
> * Caller hears music on hold file #1, playing from the beginning
> * After 30 seconds, the caller will hear the announcement
> * Caller hears music on hold file #1, playing from the beginning
> * After 30 seconds, the caller will hear the announcement
> * ...
> E.g., if the periodic announcement is made every 30 seconds the caller will only ever hear the first 30 seconds of music on hold over and over again.
> I don't fully understand the issue reported in ASTERISK-24329, but if this new behavior is indeed desirable in some cases I think it should be made configurable with the default behavior reverted back to how it was in 15.2.



--
This message was sent by Atlassian JIRA
(v6.2#6252)