[asterisk-bugs] [JIRA] (ASTERISK-29852) make_version uses GNU-ism that break git-svn-id parsing on NetBSD

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257786#comment-257786 ] 

Friendly Automation commented on ASTERISK-29852:
------------------------------------------------

Change 17878 merged by Kevin Harwell:
build_tools/make_version: Fix sed(1) syntax compatibility with NetBSD

[https://gerrit.asterisk.org/c/asterisk/+/17878|https://gerrit.asterisk.org/c/asterisk/+/17878]

> make_version uses GNU-ism that break git-svn-id parsing on NetBSD
> -----------------------------------------------------------------
>
>                 Key: ASTERISK-29852
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29852
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/BuildSystem
>    Affects Versions: GIT
>         Environment: NetBSD 9.2
>            Reporter: Michał Górny
>            Assignee: Michał Górny
>            Severity: Trivial
>
> {code}
> SVN_REV=`${GIT} log --pretty=full -1 | ${GREP} -F "git-svn-id:" | sed -e "s/.*\@\([^\s]*\)\s.*/\1/g"
> {code}
> The "\s" is a GNU-ism and does not work with NetBSD sed. As a result, git-svn-id processing does not work correctly on this system. For example, if I create an artificial commit with git-svn-id, on Linux I get:
> {code}
> SVN-trunk-r434708
> {code}
> but on NetBSD, I get:
> {code}
> SVN-trunk-r git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@434708 65c4cc65-6c06-0410-ace0-fbb531ad65f2M
> {code}
> The POSIX {noformat}[[:space:]]{noformat} can be used in place of \s.



--
This message was sent by Atlassian JIRA
(v6.2#6252)