[asterisk-bugs] [JIRA] (ASTERISK-29856) res_rtp_asterisk: Invalid comparison creates unreachable code

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257768#comment-257768 ] 

Friendly Automation commented on ASTERISK-29856:
------------------------------------------------

Change 17890 merged by Joshua Colp:
res_rtp_asterisk: Fix typo in flag test/set

[https://gerrit.asterisk.org/c/asterisk/+/17890|https://gerrit.asterisk.org/c/asterisk/+/17890]

> res_rtp_asterisk: Invalid comparison creates unreachable code
> -------------------------------------------------------------
>
>                 Key: ASTERISK-29856
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29856
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 18.9.0
>            Reporter: N A
>            Assignee: N A
>
> This code doesn't make any sense: https://github.com/asterisk/asterisk/blob/59fcd1e7e20de07ceece67e27d7db7260d465772/res/res_rtp_asterisk.c#L5760
> This flag isn't set initially, and the code reads (if flag is set, set the flag).
> I think the if comparison is missing a not here.



--
This message was sent by Atlassian JIRA
(v6.2#6252)